diff options
| author | Nao Pross <np@0hm.ch> | 2024-04-29 14:32:37 +0200 |
|---|---|---|
| committer | Nao Pross <np@0hm.ch> | 2024-04-29 14:32:37 +0200 |
| commit | 21590840570657ad046c4b73ea86baebe01ddb7b (patch) | |
| tree | 7e8dc34535c380819d9767cc6650fe9cf440c60c | |
| parent | Add sphinx documentation generator (diff) | |
| download | polymatrix-21590840570657ad046c4b73ea86baebe01ddb7b.tar.gz polymatrix-21590840570657ad046c4b73ea86baebe01ddb7b.zip | |
Add minor comments
| -rw-r--r-- | polymatrix/expressionstate/mixins.py | 2 | ||||
| -rw-r--r-- | polymatrix/polymatrix/typing.py | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/polymatrix/expressionstate/mixins.py b/polymatrix/expressionstate/mixins.py index 9c30475..0e61591 100644 --- a/polymatrix/expressionstate/mixins.py +++ b/polymatrix/expressionstate/mixins.py @@ -41,7 +41,7 @@ class ExpressionStateMixin( index = IndexRange(start=self.n_variables, end=self.n_variables + size) # FIXME: this is the only way the typechecker is happy, and it does - # make sense indeed because ExpressionState is not a dataclass + # make sense because ExpressionState is not a dataclass. # The typechecker should be somehow informed that this is an ABC that # will eventually become a dataclass, but of course it can't know that from .impl import ExpressionStateImpl diff --git a/polymatrix/polymatrix/typing.py b/polymatrix/polymatrix/typing.py index cebf636..2aa3f76 100644 --- a/polymatrix/polymatrix/typing.py +++ b/polymatrix/polymatrix/typing.py @@ -65,6 +65,8 @@ class MonomialIndex(tuple[VariableIndex]): # they have the same degree the index counts if self.degree == other.degree: # Assumes that monomialindex is sorted! + # FIXME: if the first variable is also the same continue until one + # finishes or the values differ. return self[0] < other[0] return self.degree < other.degree |