remove shape property, introduce accumulate function, reimplement derivative expression

1 files changed, 7 insertions, 7 deletions

diff --git a/polymatrix/expression/mixins/additionexprmixin.py b/polymatrix/expression/mixins/additionexprmixin.py
index 776e952..cab8161 100644
--- a/polymatrix/expression/mixins/additionexprmixin.py
+++ b/polymatrix/expression/mixins/additionexprmixin.py
@@ -20,10 +20,10 @@ class AddExprMixin(ExpressionBaseMixin):
     def right(self) -> ExpressionBaseMixin:
         ...
 
-    # overwrites abstract method of `ExpressionBaseMixin`
-    @property
-    def shape(self) -> tuple[int, int]:
-        return self.left.shape
+    # # overwrites abstract method of `ExpressionBaseMixin`
+    # @property
+    # def shape(self) -> tuple[int, int]:
+    #     return self.left.shape
 
     # overwrites abstract method of `ExpressionBaseMixin`
     def apply(
@@ -39,8 +39,8 @@ class AddExprMixin(ExpressionBaseMixin):
 
         for underlying in (left, right):
 
-            for row in range(self.shape[0]):
-                for col in range(self.shape[1]):
+            for row in range(left.shape[0]):
+                for col in range(left.shape[1]):
                     
                     if (row, col) in terms:
                         terms_row_col = terms[row, col]
@@ -64,7 +64,7 @@ class AddExprMixin(ExpressionBaseMixin):
 
         poly_matrix = init_poly_matrix(
             terms=terms,
-            shape=self.shape,
+            shape=left.shape,
         )
 
         return state, poly_matrix